-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken link at definitions.SshPublicKey.keyData.description
.
#12530
Fix broken link at definitions.SshPublicKey.keyData.description
.
#12530
Conversation
modified: specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json Fix broken link at `definitions.SshPublicKey.keyData.description`.
Hi, @edburns Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2020-10-01-preview |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
Swagger Generation Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please let me know when this is good to merge
@ArcturusZhang this was just a trivial broken link fix, so I don't know what else needs to be done. I don't understand how the pipeline failures could be related. |
The dot net pipeline is quite unstable - therefore we can ignore this failure and merge this PR. |
modified: specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json Fix broken link at `definitions.SshPublicKey.keyData.description`.
modified: specification/compute/resource-manager/Microsoft.Compute/stable/2020-06-01/compute.json
Fix broken link at
definitions.SshPublicKey.keyData.description
.MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
ARM API Review Checklist
Breaking Change Review Checklist